-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.x breaks animated-outlet #467
Comments
@rwwagner90 would you mind to setup simple github repo with reproduction? I think this will make debug much simpler and we can be sure we look into the same thing. IMO from first glance, nothing suspicious pops up in terms of v1 vs v0.12 |
Yeah, very little in ember-animated itself changed. Maybe ember version
matters? With animation timing even browser changes have mattered in the
past.
…On Sat, Apr 30, 2022 at 10:07 PM Sergey Astapov ***@***.***> wrote:
@rwwagner90 <https://github.com/rwwagner90> would you mind to setup
simple github repo with reproduction? I think this will make debug much
simpler and we can be sure we look into the same thing.
IMO from first glance, nothing suspicious pops up in terms of v1 vs v0.12
—
Reply to this email directly, view it on GitHub
<#467 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACN6MSKOANWEC2SCEVS6E3VHXRNNANCNFSM5UZEE6SQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
If I downgrade ember-animated to 0.12.0 it works. If I update to 1.x, it breaks, so I don't think the Ember version matters. I have also been getting a ton of issues with embroider and when any embroider packages go above 1.3.0 my build fails. I'm wondering if there is something with updating to a v2 addon and the v1 compatibility layer at play here? I'll try to throw together an example project sometime or I could give you access to Swach temporarily to debug there. I pasted all the code from the component above as well though, so if you have a project you could drop it in, you should see the |
@RobbieTheWagner we hit the same "flashy behavior" you were discussing when using your outlet approach and upgrading an app from Digging in further here, it seemingly is resolved or broken by the addition of this line here: If I have an app with Should have more time to dig in on this tomorrow, but curious if anyone else can replicate what I'm seeing |
Following up here, I built out a reproduction (https://github.com/acorncom/animated-outlet-bug-reproduction) that shows the "flashy behavior" when switching between routes. Installation of This still looks like it is somehow triggered by the use of:
which is actually loading up ember-scheduler in ember-animated: ember-animated/addon/src/-private/ember-scheduler.ts Lines 16 to 34 in 8ce1a4d
In the
|
@acorncom are you saying dropping a |
@RobbieTheWagner that's what I'm seeing, yes. The panel doesn't even have to be open. So in theory you could hide it with some targeted CSS. Quite interested to hear if it works for you as well |
I can confirm that this is still a bug and dropping a random |
@RobbieTheWagner no, would need to dig in to see what may be wrong. |
I have replaced animated-outlet with ViewTransitions now. Check out this great example https://github.com/tcjr/view-transitions-demo |
Describe the bug
@ef4 gave me a rough implementation of animated-outlet, so we could use this instead of liquid-fire. It was something like:
This worked great in 0.12.0, but has some weird flashy behavior in 1.x. Any thoughts on what could be going on here or what changes I might need to make?
To Reproduce
As part of your reproduction, please fork the Ember Animated Boilerplate Twiddle then list the steps for the behavior.
Here's the Ember Animated Boilerplate Twiddle: https://ember-twiddle.com/d83c87fb8a7bdfa5a55b9a3c2bb4c2e5?openFiles=templates.application.hbs%2C
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: