Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting "Error: Unimplemented" when using moveOver transitions #208

Open
AriasBros opened this issue Apr 20, 2020 · 5 comments · May be fixed by #233
Open

Getting "Error: Unimplemented" when using moveOver transitions #208

AriasBros opened this issue Apr 20, 2020 · 5 comments · May be fixed by #233
Labels

Comments

@AriasBros
Copy link

Hi,

I am getting the error Unimplemented when I try to use the moveOver transitions (anyone, I tried with the four transitions).

The exception is thrown only when I change to other route where the same component is used. For example, I use the component in /teams and /team/1 routes, so, if I try to navigate between these routes, I got the error. If I navigate to some of these routes from other route (/leagues, for example), the error doesn't happen.

I have this in my component:

  <AnimatedContainer class="player-slot__footer__animated-container">
    {{#animated-value this.price rules=this.rules as | price |}}
      <div class="player-slot__footer__price">
        <span class="player-slot__footer__price__amount">
          ${{format-number price minimumFractionDigits=1 maximumFractionDigits=1}}m
        </span>

        <Player::Revaluation @player={{this.player}} @type="season" class="player-slot__footer__price__revaluation" />
      </div>
    {{/animated-value}}
  </AnimatedContainer>
  rules({ oldItems, newItems }) {
    if (oldItems[0] < newItems[0]) {
      return toDown;
    } else {
      return toUp;
    }
  }

I am not using a bug issue for this because, as the exception say, what I am trying to do seems to be an
unimplemented thing. But I can't understand what I am doing "wrong" to get this exception, I am following the examples in the documentation.

Can someone say me a workaround to this problem?

I attach 2 screenshots with the exception.

Captura de pantalla 2020-04-20 a las 14 52 12
Captura de pantalla 2020-04-20 a las 14 52 27

@stukalin
Copy link

stukalin commented Jun 2, 2020

Same here with the {{animated-if}}...

@fusion2004
Copy link

It seems to do with the moveOver transitions always expecting there to be a kept or inserted sprite. I ran into this with {{animated-if}} and I was able to fix it by adding an empty div as an else case!

<AnimatedContainer>
  {{#animated-if this.errored rules=this.rules}}
    <MyErrorComponent />
  {{else}}
    <div></div>
  {{/animated-if}}
</AnimatedContainer>

@RobbieTheWagner
Copy link
Contributor

@ef4 any chance we could get rid of the unimplemented errors entirely? We have one we cannot even make happen, but happens under some random conditions, and starts blowing up our error log.

@ef4
Copy link
Contributor

ef4 commented Jul 8, 2020

Yes, absolutely. The error is called "unimplemented" because it's just not written, there's no fundamental limitation. Please do implement.

@dwilhelmi dwilhelmi linked a pull request Aug 7, 2020 that will close this issue
@Benkooo
Copy link

Benkooo commented Sep 1, 2022

Any update regarding this error please?

@SergeAstapov SergeAstapov linked a pull request Sep 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants