Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sections by category, not by name #134

Open
PaoloS02 opened this issue Apr 19, 2021 · 1 comment
Open

Handle sections by category, not by name #134

PaoloS02 opened this issue Apr 19, 2021 · 1 comment

Comments

@PaoloS02
Copy link
Contributor

As suggested in issue #117 in order to avoid ambiguity when selecting the sections for the size benchmark, we should select them by category rather then by name.
Categories selected through options --text, --data, --rodata and --bss should be grouped by looking at the attributes of the sections, like for elf the flags: SHF_WRITE, SHF_ALLOC, SHF_EXECINSTR.
The same should apply to the macho format, with its own flags (advice on this is welcome).

@Roger-Shepherd
Copy link
Contributor

Roger-Shepherd commented Apr 19, 2021

This requires input from someone with either macho expertise or some time. I've found it difficult to locate up-to-date macho documentation. Even the lief sources don't appear to be completely up-to-date.....

This proposal also raises the issue of whether to/how to maintain backward compatibility. This was a consideration for the way in which macho handling has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants