Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc version check should be exact #19

Open
ewingrj opened this issue Jan 9, 2019 · 0 comments
Open

solc version check should be exact #19

ewingrj opened this issue Jan 9, 2019 · 0 comments

Comments

@ewingrj
Copy link

ewingrj commented Jan 9, 2019

Currently the solc version checks that the installed version is > the requested version. However it should check for an exact match. When I specify a solc version in embark.json, I expect the contracts to be compiled with that version.

Current behavior when using this plugin...

If solc is available via solc cmd, & solc version > embark.json solc version, use that.
else, use solcjs with specified solc version from embark.json.

Thus leading to different end results for different repo installations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant