Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nvim-lsp): updated highlight group names #29

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

pyrho
Copy link
Contributor

@pyrho pyrho commented Nov 13, 2020

👋

diagnostic-nvim got more or less merged with neovim master; and with that the highlight group names have been changed for consistency with the rest of the LSP related stuff.

I chose to leave the previous groups in there so that it won't mess up the install for people not running bleeding edge neovim:master.

See nvim-lua/diagnostic-nvim#73 for more info.

Screenshot 2020-11-13 at 18 18 13

@skbolton
Copy link
Collaborator

skbolton commented Nov 13, 2020

Thanks for staying on top of this. I am guessing when neovim hits version 5 as an official release we can delete the old legacy rules?

@pyrho
Copy link
Contributor Author

pyrho commented Nov 13, 2020

I am guessing when neovim hits version 5 as an official release we can delete the old legacy rules?

Indeed, but there is a high chance that I'll forget to do that when nvim 5 will be out (:

@skbolton
Copy link
Collaborator

I'll watch it as well and make the change when time comes. Thanks again.

@skbolton skbolton merged commit 40ae829 into embark-theme:master Nov 13, 2020
@pyrho pyrho deleted the fix/lsp-diagnostic-update branch November 13, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants