Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag for cast to any not rendered types #17

Open
francescoagati opened this issue Jun 18, 2019 · 6 comments
Open

flag for cast to any not rendered types #17

francescoagati opened this issue Jun 18, 2019 · 6 comments

Comments

@francescoagati
Copy link

hi,
in some case (enum abstract) hxtsdgen block the output process with this error.
i think that should be better launch a warning but without block the process and cast to any.
or have a flag for don't throw an exception and only a warning and cast the unknown type to any

https://github.com/nadako/hxtsdgen/blob/bfb4062eb6ab519e8091aded83fcdea123fcf792/src/hxtsdgen/TypeRenderer.hx#L85

@elsassph
Copy link
Owner

What branch are you testing? Is that master or branch feature/6_include-related in PR?

@elsassph
Copy link
Owner

But I agree a warning would be better

@francescoagati
Copy link
Author

master

@elsassph
Copy link
Owner

Please try the branch if you don't mind

@cancerberoSgx
Copy link
Contributor

cancerberoSgx commented Aug 6, 2019

Is there a PR for this ? If fixed please could you update haxelib repo ? I currently need to comment that line - just a warning is enough here since probably will take some time to support all clases... Should I PR ? Maybe a flag as argument / macro to throw. (by default should not) Thanks, nice project!

@elsassph
Copy link
Owner

elsassph commented Aug 6, 2019

You're right, it shouldn't throw but print a warning. Please PR if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants