Color problem

[adrillovi]

Hi.
I uploaded some icons and the colors don't match with the original png's. Don't know what could happened.
It would be nice to fix it for the community.

[elrumo]

Hi, thanks for the submission in the first place!

I think the problem might be with image compression, what icon is it so I can look into it? Also, I might just be the preview on the website, have you tried downloading the .icons file? That file might be alright.

[adrillovi]

Hello again. Yep, I tried to download the icons and the colors still don't match. All of my submissions have the same problem: AutoCAD Alt, Pages Alt 2, Numbers Alt 2, Keynote Alt 2, Prime Video and Windows (especially remarkable in AutoCAD). I uploaded the PNG files in high quality exported directly from Sketch. That's what the web page asks. El jue., 12 nov. 2020 a las 11:28, Elias (<[email protected]>) escribió:

…

Hi, thanks for the submission in the first place! I think the problem might be with image compression, what icon is it so I can look into it? Also, I might just be the preview on the website, have you tried downloading the .icons file? That file might be alright. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#703 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARTQTWYMW3MJLPOTHEIMMRTSPO2EXANCNFSM4TTDAWHQ> .

[isametry]

Hi @elrumo, unfortunately, the issue still exists. It's a problem in color conversion which desaturates the colors in the icns compared to the original png. The backend which creates the icns bundles probably doesn't handle the embedded color profiles of the image, or at least not all of them.

For instance, below you can see my original PNG file, which was exported with the Display P3 profile, and then the contents of the generated icns file below, ostensibly converted to sRGB.

(I don't know if the difference will be visible on every display, but on a MacBook's display, the converted image is clearly washed out compared to the original.)

Edit: the ICNS can be found on my profile – https://macosicons.com/#/u/isametry

[isametry]

I'd be glad to do some testing and help resolve this issue – I have some knowledge of color management, but unfortunately no development experience.

For example, if there's a way to generate ICNS files without publishing them and spamming the production database, like an API, I can try converting PNGs with different color profiles and come back with the results.

[YousufSSyed]

I have the same issue: #1412