This repository has been archived by the owner on Aug 23, 2018. It is now read-only.
Fix overflow and position CSS in Errors.elm #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #206 . The problem was twofold:
overflow: autoto the parent, to bound the child within the parent.margin-{left,right}: autorules to the flex child. That sounds like it'd be redundant in the presence of thealign-items: centerrule, but they do have an effect, and they fix the issue.width: 100%rule on the outermost div, which was the inherited value anyway, so I removed it.I found this explanation helpful throughout while debugging/making these changes.
I was unable to test this change locally due to the build instructions not being update to date for 0.17 (or rather, the expando branch that the build instructions have one checkout is not able to be elm-make'd), but making these changes by hand in current elm-reactor fixes the issues.