-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default loop output transforms are too intrusive #362
Comments
My suggestion is to get rid of 👍 for the trainer returning Perhaps it is best to do these changes sooner than later, since they are breaking? |
For supervised training loops, we provide a convenience output transform which ensures only the model state is returned from the training loop. This means you always lose the entire training state, which might be of interest later on.
I propose instead that we return a tuple:
{loop_state, transformed_state}
which always returns the whole state, as well as a transformed version. That way you never accidentally lose the entire state.The text was updated successfully, but these errors were encountered: