Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement run state QUEUED and replace current QUEUED state with INITIALIZING #59

Open
uniqueg opened this issue Oct 9, 2018 · 0 comments
Labels
priority: medium Medium priority type flag: required by specs Compliance with specs requires this change type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve

Comments

@uniqueg
Copy link
Member

uniqueg commented Oct 9, 2018

Is your feature request related to a problem? Please describe.
Currently, the flow of states for new workflow runs starts with UNKNOWN, then proceeds to QUEUED as soon as a worker picks up a task/run, and then almost instantly changes to RUNNING when cwl-tes execution is triggered in the background. However, with regard to state QUEUED, this flow makes little sense, because the actual queuing - when there is sufficient load and depending on the Celery config - happens on the broker, i.e., after a task is published but before a worker picks it up.

Describe the solution you'd like
The signal after_task_publish should be leveraged to change a run's state to QUEUED while the event task-received would be used to bump the run state from QUEUED to INITIALIZING (instead of UNKNOWN to QUEUED as is currently the case). Note the difference between signals and events and that the after_task_publish signal is sent in the process sending the task, not by the worker.

Describe alternatives you've considered
N/A

Additional context
N/A

@uniqueg uniqueg added this to the Release candidate v1.0.0-rc milestone Oct 9, 2018
@uniqueg uniqueg removed this from the Release candidate v1.0.0-rc milestone Sep 1, 2019
@uniqueg uniqueg added bh19 and removed enhancement labels Sep 1, 2019
@uniqueg uniqueg added short and removed medium labels Sep 4, 2019
@uniqueg uniqueg removed bh19 labels Feb 20, 2020
@uniqueg uniqueg added priority: medium Medium priority type flag: required by specs Compliance with specs requires this change type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve labels Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium priority type flag: required by specs Compliance with specs requires this change type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve
Projects
None yet
Development

No branches or pull requests

1 participant