fix: remove warnings while loading locales #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for the PR, greatly appreciated. I have published ex_cldr_strftime version 1.0.0 since the API hasn't changed in a year. The changelog reads: Enhancements
I also fixed a dialyzer issue in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
It seems recent versions of
elixir-cldrdeprecated some function calls incldr_strftimeand I had my build failing (due tomix compile --warnings-as-errors).This PR solves these warnings. However, I'm not sure if more changes are needed (version bump, maybe?).
Please let me know and I'll be happy to update anything.
Cheers!