Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let effects declare they depend on global transform #11

Closed
tkarabela opened this issue Nov 10, 2020 · 1 comment
Closed

Let effects declare they depend on global transform #11

tkarabela opened this issue Nov 10, 2020 · 1 comment

Comments

@tkarabela
Copy link
Contributor

Now that we have #5, I've tried it in the Blender implementation and noticed that while the transform is passed correctly, it only gets passed in once when the modifier is created. Changing the transform interactively does not lead to re-cooking.

This seems like good default behavior and optimization, but it makes the transform kinda pointless.

We should let the effect declare at describe time that it depends on the transform, so that the host can re-cook it as needed. Should it be "global" like the deformer property, or tied to input mesh (so that the effect can depend on transform of some input, but not other input - would that be even useful)?

@tkarabela tkarabela changed the title Let attributes declare they depend on global transform Let effects declare they depend on global transform Nov 10, 2020
@eliemichel
Copy link
Owner

eliemichel commented Jan 2, 2021

Fixed with the introduction of kOfxInputPropRequestTransform in 3fb92c3
Equivalent in the C++ SDK is inputDef.RequestTransform().

Blender_.C__tmp_untitled.blend.2021-01-02.19-50-06_reenc.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants