Remove unused "id" field from parser and api_format #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #417
we can merge this or leave old code as is. up to your liking.
story:
idfield looks unused. it was added 3 years ago, but then i do not see any usage neither in burst or elementum.for duplicates
hashis used -script.elementum.burst/burst/filtering.py
Line 810 in 0de57c9
in elementum there is no such field for TorrentFile - https://github.com/elgatito/elementum/blame/master/bittorrent/torrent_file.go#L35
maybe it was supposed to be used to find duplicates, but then this idea was abandoned.
after removing all lines added in the commit above - nothing changed in terms of search.