-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Trakt Progress page #46
Comments
But look on my comments here: The best implement of this category is in SALTS. |
I saw that thread too. Regarding the difference you asked about on that thread. On the trakt website by the default shows by default shows all shows. Including the ones you have finished etc. It's possible to filter these out. I'm not sure how salts works, but in Exodus, shows that you were up to date on (i.e. next episode is in the future or there is no next episode), it would filter them out. Otherwise the show was shown, and if you opened it, it would list all next shows to watch. If after the next episode to watch, there were more episodes and they were not aired yet, they would be greyed out. I think that's more than enough usability. |
Actually, I think you're mistaking this feature request with what was already implemented. The PR I linked to is what you were asking for. |
You are welcome to try 0.0.35 with Progress page. |
When I go to TV Shows > Trakt, the following notification comes up:
|
Oh. You have cached list. Can delete cache.db or wait |
Thanks @elgatito ! But I have some improvement requests (Regarding the SALTS addon that also implemented it):
Bug?
Thanks. |
Great! It works. Life will be much better with this. Thank you so much! I think one other cool thing would be to separate episodes into a new page. I.e. when going into |
By the way, I'm happy to help with stuff, however, I need some guidance on setting up a dev environment as I mentioned in #48 |
@hoshsadiq |
You can open "History" page, which shows the same order of the same shows, which you can enter and select the episode and so on. |
I remember. I will make some docs when I finish with basic stuff and it becomes more stable. |
I will not color anything. People have different skins and colors. Forcing colors is a bad idea.
We get list of shows from Trakt sorted by "last watched". Custom sorting of items is done by Kodi, not the plugin.
We get information about names from TMDB. You can edit information there, it's open for changes. |
|
Use original Trakt movies/episodes when browsing Trakt lists, by default we always use TMDB for information. |
I have enabled it, but the info is still taken from TMDB instead of Trakt. |
Both history and collections is not what I'm looking for, the way I've described it earlier (listening only the shows, then going into episodes) is how Kodi acts, hence why imo it should be a seamless experience.. Progress is meant to hide everything that you've already fully watched. I've realised today that this is not the case. It shows future episodes. |
I think instead of "Progress", it should be called "My next episodes". @hoshsadiq |
Because you're not necessarily up to date with the shows. If you have a show that is on season 2 episode 5 for example, and you've only seen season 1, you've got 5 episodes left. The way it's implemented, you watch an episode, then you have to wait for it to refresh (which actually, oddly takes longer than all other menus) then you can watch the next episode. 2 more things |
You don't see a show when there is no unwatched episode in the queue.
No. If you want to start watching old show - you won't see it in the list because air date was too long ago. Other side you want to watch new show - you will see only old shows with earlier air dates. If you want to see list of episodes on the show - it's what Kodi does for you in the library. |
I'm also agree with @elgatito , the content of this list is correct and this is how it should be. One thing I agree is about the sorting issue as I mentioned before,
And I think it's important and would be nice to mention the air date in the start of the title, because all the point in this list is to see the air dates. Thanks. |
Sorry, I think you misunderstood me, the next sentence was part of it too. It seems that episodes that are not aired yet (but are listed on trakt as a future episode), are also listed in progress. For example, I have The Flash in my watch list, which currently I'm up to date on. Last episode aired was 4x11, which aired on Jan 24. When I go to progress, it shows The Flash with next episode being 4x11. Now I watched that episode yesterday, and now it shows 4x12, which hasn't been aired yet (airs tomorrow), and is therefore not possible to watch. These should be filtered out from the list. |
I just looked at the docs for that endpoint. The documentation says:
However, when doing the request I get the following:
with the following headers
Based on the docs, This explains my previous comment. I'm trying to find a place where I can report this as a bug to see if their devs can look into it. |
Yes, it should have been set to null. I will add a check there to skip those items.
Not sure where to report. There is a Google+ community for Trakt API, but not sure if that is the right place. Still it's so much slow, you need to get list of shows, then request each show and only after that you know how much of them have available episodes. One more thing is that Trakt can have empty TMDB link or link to wrong TMDB item, so we fetch the show and it does not exist and we skip it's output, so the list is again broken (not filling right number of items). |
For me it's not a bug so I hope they won't fix that :) |
@elgatito
Thanks. This is very helpful.
Agreed. I am happy to contact the devs and request this endpoint if you'd like. It would be nice to improve the speed of this page. Lastly, apparently the G+ community you mentioned before is the right place for such questions. I've asked if it makes more sense to have a Github community. |
Can you add it as an option in the Settings? Because there are some other that want it as it's working now (Without skip those items) |
@burekas7 maybe I'm misunderstanding your use case, but going to |
@hoshsadiq Here in 'Progress' is exactly what I meant to (Like it is done in SALTS addon and calls there as 'My Next Episode'), when it shows all the next/future episodes of TV Shows that you are watching (Those that already aired and those that still not aired yet but has future air date). In SALTS by the way, as I show here, there is an option in their settings for filter out these unaired episodes, like what you need I guess. |
I have used the existing "show unaired episodes" options to influence listing episodes in Progress with "Aired" being after now. I would be fast if we just use paging and split to usual number per page. But. We are checking each trakt show with TMDB database and some items should be dropped off the list, then we check episode, which also can be not in the TMDB database, and then it can be in the future, so also drop off, so you see you are getting less then required items per page. If it's the first page - it's fine, if not first - it's too ugly. |
@elgatito I made a feature request on their G+ page: https://plus.google.com/104974452270599315078/posts/QpHJJ7y7n3t |
@hoshsadiq I have totally loose the point of this issue. Can you describe how you see the desired progress page and what should be there? |
Yes, sorry, so I think I neglected to mention that I always have the below filter on. I think adding the additional airdate as @burekas7 mentioned, and hiding the items that have future airdates (possibly through an option considering there are people who want them in the list) is what my I had in mind. Having those two imo would be enough for this issue to be closed |
Changes in v0.0.54:
Closing this one. Let it be a separate issue if there is something else to do with the progress page. |
On Trakt you have a TV show progress section (https://trakt.tv/users/<user>/progress/watched/activity) that tells you what the next episode of your unfinished shows is. Would be cool to have this. I think this has already been implemented in this PR: scakemyer/quasar#40 but I imagine some changes will be required as I've seen some major refactoring in elementum.
The text was updated successfully, but these errors were encountered: