Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elementum 0.1.101 Original title setting #1026

Open
tibikepc opened this issue Apr 20, 2024 · 8 comments
Open

Elementum 0.1.101 Original title setting #1026

tibikepc opened this issue Apr 20, 2024 · 8 comments

Comments

@tibikepc
Copy link

Hello in this version,missing original title setting,the ncore.cc provider (hungarian) for many things no result search.

@antonsoroko
Copy link

antonsoroko commented Apr 20, 2024

@tibikepc
First of all, you must have provided this info:

  1. Have you had this option enabled or disabled?
  2. What is your Kodi's interface language?
  3. What languages Ncore supports for searching?

Without this info I can only make some guesses.


This logic was moved to burst settings.
Now elementum always sends "original" title to burst and other search addons.
In burst you can enable or disable translation of title, the option is called "Use Kodi language".
So if you want to search titles in your Kodi language - then enable this option.
Also, provider (torrent tracker) can have their own language defined in "language:" field. If defined then this language will be used. Also several languages can be used if they specified in "*_keywords:" fields (e.g. "title:original:en:fr").
The precedence is: languages from _keywords (if defined), kodi's language (if setting is enabled), provider's language (if defined), original language of video. code.

I guess Ncore tracker is not defined correctly. Right now it is configured to use user's language if you enabled the option, otherwise it will use "original" title (if option is not enabled).
(If you see that it acts different from what I described - provide debug log file. Link to guide was in issue template.)

If that tracker supports only specific language/languages for searching - then create PR to change provider's "language:" and "*_keywords:" fields to reflect language that this provider supports for searching. Here is the definition https://github.com/elgatito/script.elementum.burst/blob/008b53cf5d781b9292655ba224e30758b158b7be/burst/providers/providers.json#L1544
If you can't make PR - create issue in burst repo with description of what languages this tracker supports.

If tracker has torrents in any language then enable or disable the option I mentioned above in burst. Note that this is global option, so it can affect other providers that do not have specific language defined in their json definition.


Discussion about moving option from elementum to burst:
#991 (comment)

@antonsoroko
Copy link

@tibikepc i made some fixes, but i made them blindly. i am still waiting for your answers for those 3 questions.
what is the point to report issues and then disappear? :-)

@tibikepc
Copy link
Author

1.This opcion was enabled.
2.Kodi interface language is Hungarian.
3.Ncore support for searching Hungarian and English.

@tibikepc
Copy link
Author

I installed back the elementum 0.1.97 and burst 0.77,this versions is perfect. I have hungarian interface language,and original title turned on,remove quotes from search query turned on.But in New version for example: game of trons,the walking dead,vikings,a true detectiv,no searching results.

@antonsoroko
Copy link

@tibikepc
have you tried latest burst?
in elgatito/script.elementum.burst#405 i added en and hu to all hungarian trackers, so regardless of your settings it will always use en and hu for search.
this is how it must be for any language specific tracker (french, russian, etc) in order to always get proper results.

(as i wrote above, you can disable "Use Kodi language" option in burst to match old behavior. but for hungarian trackers it does not matter anymore b/c of changes that i described above).

@antonsoroko
Copy link

antonsoroko commented May 13, 2024

@tibikepc
i tested on ztracker and itorrents for "game of thrones" s01e01 - both show me some results.
i do no have access to other hungarian trackers , so i can't test them.

if you see different results for new and old versions then
please provide logs from new and old versions so i can compare what is different from technical point of view.

@tibikepc
Copy link
Author

The problem is in the ncore provider

@antonsoroko
Copy link

@tibikepc

if you see different results for new and old versions then
please provide logs from new and old versions so i can compare what is different from technical point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants