Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added seeds to lineage. #1694

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Added seeds to lineage. #1694

merged 1 commit into from
Sep 5, 2024

Conversation

elongl
Copy link
Member

@elongl elongl commented Sep 5, 2024 •
edited by github-actions bot
Loading

null

@linear Linear
Copy link

linear bot commented Sep 5, 2024

ELE-3610 Add seeds to lineage

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

👋 @elongl
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@elongl elongl force-pushed the ele-3610-add-seeds-to-lineage branch 7 times, most recently from 9660eaf to e4b7aa7 Compare September 5, 2024 12:12
@elongl elongl force-pushed the ele-3610-add-seeds-to-lineage branch from e4b7aa7 to 309c541 Compare September 5, 2024 12:17
ofek1weiss
ofek1weiss reviewed Sep 5, 2024
View reviewed changes
elementary/monitor/api/lineage/schema.py
def _format_node_id(cls, node_id: str):
# Currently we don't save seeds in our artifacts.
# We remove seeds from the lineage graph (as long as we don't support them).
if re.search(_SEED_PATH_PATTERN, node_id):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the const

elementary/monitor/dbt_project/models/alerts/alerts_v2.sql Outdated
@@ -22,6 +22,9 @@
-- depends_on: {{ ref('dbt_sources') }}
-- depends_on: {{ ref('elementary', 'dbt_source_freshness_results') }}

-- depends_on: {{ ref('dbt_seeds') }}
-- depends_on: {{ ref('seed_run_results') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@elongl elongl merged commit b42805a into master Sep 5, 2024
2 of 3 checks passed
@elongl elongl deleted the ele-3610-add-seeds-to-lineage branch September 5, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek1weiss ofek1weiss ofek1weiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elongl @ofek1weiss