Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ele 1706 add to freshness result criteria #1175

Merged
merged 10 commits into from
Sep 28, 2023
Merged

Ele 1706 add to freshness result criteria #1175

merged 10 commits into from
Sep 28, 2023

Conversation

NoyaArie
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Sep 26, 2023

ELE-1706 save source freshness criteria field

  • keep the error field - maybe we can support upgrading the cli package only
  • warn_after, error_after, and filter - add to dbt_source_freshness_results

In addition:

  • normalize the status value in the alerts (error = failed, runtime_error = error)

@github-actions
Copy link
Contributor

👋 @NoyaArie
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

IDoneShaveIt
IDoneShaveIt approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@IDoneShaveIt IDoneShaveIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoyaArie NoyaArie merged commit 1d4ed75 into master Sep 28, 2023
3 checks passed
@NoyaArie NoyaArie deleted the ele-1706-add-result-description-to-source-freshness branch September 28, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDoneShaveIt IDoneShaveIt IDoneShaveIt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoyaArie @IDoneShaveIt