Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display emoji reactions #783

Closed
7 tasks done
Tracked by #1067
flescio opened this issue Apr 7, 2023 · 7 comments
Closed
7 tasks done
Tracked by #1067

Display emoji reactions #783

flescio opened this issue Apr 7, 2023 · 7 comments
Labels
A-Reactions T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@flescio
Copy link
Contributor

flescio commented Apr 7, 2023

Your use case

Tasks

  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion

Designs

Rust Data

timeline.rs EventTimelineItem.reactions() will expose the reactions for a given event

Dependency

Expose more data in EventTimeline's Reactions

@flescio flescio added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 7, 2023
@langleyd
Copy link
Member

langleyd commented Jul 5, 2023

#1158

@langleyd langleyd linked a pull request Jul 5, 2023 that will close this issue
3 tasks
@langleyd langleyd removed a link to a pull request Jul 5, 2023
3 tasks
@langleyd
Copy link
Member

langleyd commented Jul 5, 2023

#1249

@kittykat kittykat added A-Reactions X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA labels Jul 11, 2023
@kittykat
Copy link
Contributor

Works on both platforms, but last point looks different on Android and iOS:

1000003562
IMG_0257

@langleyd
Copy link
Member

Sorry, one of the checkboxes should not have been checked. The add more button will be added on iOS in #1314.

There are a few other discrepancies that will be cleaned up soon:

  1. I think android should be filling the second row with emojis and adding he expand collapse as the end of the second row.
  2. It's technically not possible to show the count on the expand button on iOS as it cause a bug that can freeze the app(an infinite loop where to get the count of those truncated we need to layout the view first -> Then update the count on the view -> which updates the layout -> loops forever). I want to review that with @callumu . It may also be an issue for android when they go to implement 1. and we may want to make the two consistent anyway with the "Show more" text.
  3. The text color looks different across iOS/Android on the "Show more/less" button.

Will resolve these shortly, thanks @kittykat !

@kittykat
Copy link
Contributor

kittykat commented Jul 19, 2023

@langleyd We also found an issue where the add more button is in the wrong order on Android when reacting to own messages: https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?type=design&node-id=2128-106960&mode=design&t=j9eT47A2LWp1vMji-0

On iOS, the UI also jumps when there is a reaction on a location event and it's removed from another session.

We are also missing the bottom sheet on Android with the list of people who reacted.

Would you like issues filed for any of those?

@langleyd
Copy link
Member

@kittykat PR incoming here for the reaction order here, and some other improvements that will bring it in line with iOS.

I have also started on the bottom sheet for reaction summary, that will probably come tomorrow.

So just an issue for the iOS jumping bug please.

@kittykat
Copy link
Contributor

Filed the UI issue: #1372

@kittykat kittykat closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reactions T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

4 participants