Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSS: room previews can be very inconsistent #3148

Closed
ara4n opened this issue Aug 10, 2024 · 2 comments
Closed

SSS: room previews can be very inconsistent #3148

ara4n opened this issue Aug 10, 2024 · 2 comments
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Aug 10, 2024

Steps to reproduce

  1. Launch app
  2. Look at room list
  3. Some room previews are very stale

It seems that if the most recent event in the room is not visible, it shows a stale cache of the room preview, causing the timestamps to jump around unpredictably.

This was previously worked around by subscribing to visible rooms with limit=20, making the chance of a stale cache much less. But it no longer seems to be working in build 674

Outcome

What did you expect?

reliable room previews

What happened instead?

see rageshake

Your phone model

No response

Operating system version

No response

Application version

674

Homeserver

No response

Will you send logs?

Yes
@ara4n ara4n added T-Defect A-SSS Regression or bug observed when using Simplified Sliding Sync labels Aug 10, 2024
@Velin92 Velin92 added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 12, 2024
@ara4n
Copy link
Member Author

ara4n commented Aug 14, 2024 •
edited
Loading

This is apparently because synapse SSS doesn't yet return history when you subscribe to rooms, and so we have less chance of having a Latest Visible Event available to accurately calculate the room preview.

@manuroe
Copy link
Member

manuroe commented Sep 3, 2024

probably fixed with #3220.

@manuroe manuroe closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @manuroe @Velin92