Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room list: "No chats yet" texts overlap when switching tabs #3144

Closed
manuroe opened this issue Aug 9, 2024 · 2 comments
Closed

Room list: "No chats yet" texts overlap when switching tabs #3144

manuroe opened this issue Aug 9, 2024 · 2 comments
Labels
A-Filters A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@manuroe
Copy link
Member

manuroe commented Aug 9, 2024 •
edited
Loading

Steps to reproduce

  1. Use an account with no room
  2. Select a filter like People
People "No chats yet" description overlaps the "No chats yet" main list. The effect varies on language

Outcome

What did you expect?

No overlap so that the description is easy to ready.

What happened instead?

Different types of overlaps that dependson the selected tab and language. First I thought there was a UI bug because I was seeing a vertical lign. Actually, it was the bottom of the "Start chat" button of the main view.
@manuroe
Copy link
Member Author

manuroe commented Aug 9, 2024 •
edited
Loading

should we display tabs when there is no rooms?
EXA does not display them.

@Velin92 Velin92 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Filters labels Aug 12, 2024
stefanceriu added a commit that referenced this issue Aug 12, 2024
@stefanceriu
Fixes #3144 - Stop showing filters when the room list is not in the `…
774109c 
…rooms` display mode
@stefanceriu
Copy link
Member

should we display tabs when there is no rooms?

We should not, no. #3156 will takes care of that.

stefanceriu added a commit that referenced this issue Aug 13, 2024
@stefanceriu
Fixes #3144 - Stop showing filters when the room list is not in the `…
83d4f34 
…rooms` display mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Filters A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanceriu @manuroe @Velin92