From 5eda85a1718d37fe4cf0bb6ff70fa6aec95eed05 Mon Sep 17 00:00:00 2001 From: Stefan Ceriu Date: Mon, 12 Aug 2024 16:52:41 +0300 Subject: [PATCH] Fixes #3144 - Stop showing filters when the room list is not in the `rooms` display mode --- ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift | 2 +- .../PreviewTests/test_homeScreen-iPad-en-GB.Empty.png | 4 ++-- .../PreviewTests/test_homeScreen-iPad-pseudo.Empty.png | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift b/ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift index b267d9cf94..7e20d00372 100644 --- a/ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift +++ b/ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift @@ -120,7 +120,7 @@ struct HomeScreenViewState: BindableState { } var shouldShowFilters: Bool { - !bindings.isSearchFieldFocused + !bindings.isSearchFieldFocused && roomListMode == .rooms } var shouldShowRecoveryKeyConfirmationBanner: Bool { diff --git a/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-en-GB.Empty.png b/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-en-GB.Empty.png index 62cb6459aa..fa5c9dea78 100644 --- a/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-en-GB.Empty.png +++ b/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-en-GB.Empty.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:c842b03844cf8ecc0cb5b6925b1124d58e74a097393d0e54e4a6415f1b51f9bf -size 114086 +oid sha256:557c03468f0eb9d0090b231b5cf37f4f73bab67be2579d1959c19fcfe9fb4bd0 +size 100235 diff --git a/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-pseudo.Empty.png b/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-pseudo.Empty.png index d9597a384e..7aae11cfd6 100644 --- a/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-pseudo.Empty.png +++ b/PreviewTests/__Snapshots__/PreviewTests/test_homeScreen-iPad-pseudo.Empty.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:7a6bf32618c6df5702936d6cd56f031f3e90797621e0c2970b977844535219ff -size 123860 +oid sha256:19547d5c1d219b6db944de78a56f056ab30110ddba88802d515b6c45c723ae9a +size 107668