Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Request to join community channels which are invite-only. #5788

Closed
5chdn opened this issue Dec 6, 2017 · 17 comments
Closed
Assignees
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@5chdn
Copy link

5chdn commented Dec 6, 2017

Description

Feature request: Allow community members to request to join community channels which are invite-only.

Steps to reproduce

  • If you are a community member, go to your community
  • Find a room you are not in yet, that is invite-only
  • Open it and click the join-room button
  • Face an error message "invite only foo bar"

It would be nice that this creates a join-request that the room owner can approve or deny instead of creating an error message for the user. That would make listing channels more useful by the way.

An alternate idea would be to allow invite-only community channels to be joined by approved community members.

Version information

  • Platform: web (in-browser) and web (in-rambox)

For the web app:

  • Browser: Chrome
  • OS: Arch Linux
  • URL: riot.im/app

Thanks. ❤️

@lampholder
Copy link
Member

lampholder commented Dec 6, 2017

An alternate idea would be to allow invite-only community channels to be joined by approved community members.

This is certainly the desired direction - we want to be able to set room access ACLs based on group membership.

It would be nice that this creates a join-request that the room owner can approve or deny instead of creating an error message for the user. That would make listing channels more useful by the way.

This would be a nice feature to have generally, if we can avoid non-members' being able to spam a room through repeated/coordinated requests to join. We've discussed this feature (and it's counterpart 'request-to-join-community' in the past and referred to it as 'knocking', but quickly searching the github issue list isn't finding anything relevant.

@5chdn
Copy link
Author

5chdn commented Dec 6, 2017

if we can avoid non-members' being able to spam a room through repeated/coordinated requests to join

Yeah, I explicitly want to allow members of the community only to request access. This will prevent "guests" from spamming internal channels.

@matthijskooijman
Copy link

I would actually like to see this more broadly, also for rooms which are not part of a community or even listed in the directory. The usecase I have in mind is:

  • I create an invite-only room
  • I send some people (who might not be on riot yet) the link
  • Have those people register on Riot (possibly as a guest), open the link and click "request to join" or something similar.
  • In Riot, I can then approve the join of these people

Currently, doing this involves asking people to register, tell them how to find their username, ask them to send me their username and then invite them, which is a bit more cumbersome (especially when dealing with new users).

I guess there is a risk of getting flooded with invite requests, but for a room that is not listed in the directory, this should probably be ok. For group rooms, adding an optional limtation to only allow group members to request to join would also make sense, as suggested before.

@ghost
Copy link

ghost commented Aug 7, 2019

Adding a vote in favour of this feature too.

At the moment with my own project we regularly have people who don't like the fact we've forked GNU Image Manipulation Program joining our channel to spam it or harass our users.

If we go invite-only then we close off our comms channels to anyone that doesn't follow us outside of Matrix. If we stay fully public, then we're forced to be constantly reactive because we can't preemptively ban people (new feature suggestion I just added at #10516). Even if we could do this we can't stop them carrying on by joining with new "throwaway" accounts.

@BloodyIron
Copy link

There's plenty of Slack rooms that are invite only, and we need a way to be able to join those, otherwise it really defeats a core aspect of Matrix/Riot, that being bridging the communication platforms.

@ghost
Copy link

ghost commented Mar 6, 2020

For those who are interested in the way our project went, we made all but one channel invite-only, then used "Server ACLs" to block "known bad" name servers on the public channel.

This is still sub-optimal as we basically have to remind people to ask us to join the invite-only channels, and we have to follow community groups to figure out which name servers and users we should pre-emptively ban.

@aaronraimist aaronraimist added the A-Spaces Spaces, groups, communities label Apr 7, 2020
@kettenfett
Copy link

adding my vote for this.

@SimonBrandner
Copy link
Contributor

Will be fixed by matrix-org/matrix-spec-proposals#2403

@hex-m
Copy link

hex-m commented Aug 12, 2021

Will be fixed by matrix-org/matrix-doc#2403

The spec change is merged and the implementation in Synapse is merged too. What's missing is the client-side.

@ShadowJonathan
Copy link
Contributor

Wouldn't this then become a dup of whatever issue exists now for "implement UI for knocking"?

@hex-m
Copy link

hex-m commented Aug 12, 2021

It would - but I didn't find one so I assume this is the issue for "implement UI for knocking".

Update: There it is: #18655

@t3chguy
Copy link
Member

t3chguy commented Jan 7, 2022

Knocking is being worked on but not as part of Spaces

@t3chguy t3chguy removed the A-Spaces Spaces, groups, communities label Jan 7, 2022
@Mikaela
Copy link
Contributor

Mikaela commented Jan 7, 2022

I think something like this is being worked on at https://github.com/matrix-org/matrix-doc/issues/3297 and matrix-org/matrix-spec-proposals#3386.

@t3chguy
Copy link
Member

t3chguy commented Jan 7, 2022

Yup, just not at all related to Spaces. but will apply to spaces just as it will to all rooms.

@SimonBrandner SimonBrandner added A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P3 labels Jan 7, 2022
@mimtud
Copy link

mimtud commented Apr 1, 2022

I do not understand the last comments, so maybe this is redundant, but is the following already considered (should I create a new issue? here or in matrix-synapse?)?
There is the (often reported) issue, that we have to make encrypted rooms invite-only so that new members can read the message history (despite the fact that the settings make you believe that you can allow space members to join the room and they would see the history then).
On top of that, Space members cannot see any of the invite-only rooms on the space home page (which, reading the OP here, was possible with "communities" before?).
So to achieve the original request, at least listing the invite-only rooms on the space home page would be necessary. Which would also allow for a new nice setting: Allow knocking only for space members.
(@t3chguy maybe?)

@IzziIP
Copy link

IzziIP commented Apr 1, 2022

Just to expand on the previous comment: even space admins are currently not able to see the complete list of invite-only rooms on the space home page (only those they are members of). w/o it's a pain to keep track of all invite-only rooms in bigger spaces.

@turt2live turt2live self-assigned this Apr 6, 2022
@turt2live
Copy link
Member

Closing in favour of #18655

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests