Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle click on download button should still try to open in a new tab #3838

Open
turt2live opened this issue May 7, 2017 · 2 comments
Open
Labels
Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed T-Enhancement

Comments

@turt2live
Copy link
Member

Description

#3640 changed the default behaviour of the download button to actually download the image. There are situations where opening the image in a new tab is still preferred (such as to not download the image, but still view it larger). While the default operation of the download button should be download, it still seems reasonable that middle clicking should open in a new tab.

Of course, this is one person's opinion on how a button should work - so feel free to tell me I'm wrong ;)

Version information

  • Platform: web (in-browser) or desktop?

For the web app:

  • Browser: Chrome 58
  • OS: Windows 10
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented May 7, 2017

https://bugs.chromium.org/p/chromium/issues/detail?id=116376

edit:
tested in FF and behaviour is as you deemed reasonable

@lampholder
Copy link
Member

I would expect middle click to open in a new tab :)

@SimonBrandner SimonBrandner added Help Wanted Extra attention is needed and removed Easy P3 labels Aug 26, 2021
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed T-Enhancement
Projects
None yet
Development

No branches or pull requests

6 participants