Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Jest test: AddRemoveThreepids › should display an error if the code is incorrect #28160

Closed
richvdh opened this issue Oct 7, 2024 · 1 comment · Fixed by #28226
Closed
Labels
A-Developer-Experience T-Task Tasks for the team like planning

Comments

@richvdh
Copy link
Member

richvdh commented Oct 7, 2024

 FAIL  test/components/views/settings/AddRemoveThreepids-test.tsx (13.309 s)
  ● AddRemoveThreepids › should display an error if the code is incorrect

    thrown: "Exceeded timeout of 5000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      255 |     });
      256 |
    > 257 |     it("should display an error if the code is incorrect", async () => {
          |     ^
      258 |         const onChangeFn = jest.fn();
      259 |         const createDialogFn = jest.spyOn(Modal, "createDialog");
      260 |         mocked(client.requestAdd3pidMsisdnToken).mockResolvedValue({

      at it (test/components/views/settings/AddRemoveThreepids-test.tsx:257:5)
      at Object.describe (test/components/views/settings/AddRemoveThreepids-test.tsx:40:1)

https://github.com/matrix-org/matrix-js-sdk/actions/runs/11214479864/job/31169646143

@dosubot dosubot bot added A-Developer-Experience T-Task Tasks for the team like planning labels Oct 7, 2024
@dbkr
Copy link
Member

dbkr commented Oct 17, 2024

We decided we probably ought tio port this to a playwright test if we can't de-flake it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants