Got incorrect room state (stuck knock requests)

[AndrewFerr]

Steps to reproduce

1. Created a room with ask-to-join access (i.e. with a join_rule of knock)
2. Many people asked to join
3. Room moderator allowed them in
4. All allowed users joined the room

Outcome

What did you expect?

All of my EW clients should show no remaining people asking to join.

What happened instead?

One of my EW clients thinks that a few users are still asking to join. Trying to grant them access fails with MatrixError: [403] {mxid} is already in the room. (https://{server_name}/_matrix/client/v3/rooms/{room_id}/invite).

Scanning the Synapse DB shows that the users really are joined, and other EW clients (which had synced incrementally) correctly see that they are joined. Logging into a new EW session (which does a full sync) also sees them as joined.

Operating system

Fedora

Browser information

Firefox 130.0.1 (64-bit)

URL for webapp

https://develop.element.io/

Application version

Element version: 11d70fe-react-a1bdceed3e54-js-42ec17b97795 Crypto version: Rust SDK 0.7.2 (7a21514), Vodozemac 0.7.0

Homeserver

Synapse v1.114.0

Will you send logs?

Yes