Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned event changes not showing up in the room timeline #28091

Closed
anoadragon453 opened this issue Sep 23, 2024 · 3 comments
Closed

Pinned event changes not showing up in the room timeline #28091

anoadragon453 opened this issue Sep 23, 2024 · 3 comments
Labels
A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented Sep 23, 2024

Steps to reproduce

  1. Have a room with some pinned messages
  2. Unpin the messages
  3. Don't see the m.room.pinned_events rendered in the timeline in any way (even if "Show hidden timeline events" is enabled)

Outcome

What did you expect?

To see the m.room.pinned_events state event rendered in the timeline as "@user:domain unpinned a room message." or similar. This is a supported feature, but there appears to be a bug preventing it from appearing.

What happened instead?

No mention of pinned messages in the timeline. However I can see the m.room.pinned_events state events in /devtools, and there are no pinned messages being shown in the room's UI. So my client definitely received the state events.

I've included some additional details (room ID, state event IDs) in the associated rageshake.

Operating system

NixOS Linux

Application version

Element version: 1.11.77 Crypto version: Rust SDK 0.7.1 (c8c9d15), Vodozemac 0.6.0

How did you install the app?

From https://github.com/NixOS/nixpkgs/

Homeserver

element.io

Will you send logs?

Yes

@dosubot dosubot bot added A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Sep 23, 2024
@anoadragon453
Copy link
Member Author

It turns out that if you turn the feature on in Labs, the events get rendered 🤦

Timo appeared had the same bug with the feature on however, so leaving this open for him to confirm.

@dbkr
Copy link
Member

dbkr commented Sep 30, 2024

Pinned messages are out of labs now - are you still getting this? I tried briefly and couldn't repro (although they did collapse slightly weirdly with a pin+unpin just collapsing to "Dave changed the pinned messages for the room." with no option to expand).

@anoadragon453
Copy link
Member Author

@toger5 says it was probably a fluke. So, closing.

@anoadragon453 anoadragon453 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

No branches or pull requests

2 participants