Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW & MAS: Clicking 'Create Account' fails on the welcome screen when using MAS #27993

Closed
wrjlewis opened this issue Sep 3, 2024 · 7 comments
Closed
Assignees
Labels
A-OIDC A-Registration O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@wrjlewis
Copy link

wrjlewis commented Sep 3, 2024

Steps to reproduce

On a MAS enabled server (beta.matrix.org for instance)

Open Element Web
See 'Welcome to Element' screen

image

Click 'Create Account'
See error message

image

Outcome

What did you expect?

To be able to create an account following this flow

What happened instead?

You get an error message

There are probably two things to consider:

  1. What should be the correct flow long-term, ie there are a couple of screens in the working flow that have sign-in and create account. The bug only happens if you click create account at the first opportunity / screen. If you click Sign In first rather than Create Account, then it works.
  2. A short term fix to get it working for now

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

beta.matrix.org

Will you send logs?

No

@wrjlewis
Copy link
Author

wrjlewis commented Sep 3, 2024

In terms of priority: the short-term fix is fairly urgent as it prevents users (when following the flow mentioned) from registering new accounts on beta.matrix.org or where-ever else we want to enable MAS.

@dosubot dosubot bot added A-Registration O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround labels Sep 3, 2024
@daniellekirkwood
Copy link
Contributor

@langleyd Can we get eyes on the short-term fix? Who is the best person to support this?

@element-hq/design Do we already have a plan for the long-term fix designed?

@americanrefugee
Copy link

@element-hq/design Do we already have a plan for the long-term fix designed?

Yes

@americanrefugee
Copy link

Also, here's the vision for MAS

@MidhunSureshR MidhunSureshR self-assigned this Sep 3, 2024
@ara4n
Copy link
Member

ara4n commented Sep 4, 2024

my suggested short term fix would be "if create user view errors, redirect the user back to the signin view".

@sandhose
Copy link
Member

sandhose commented Sep 4, 2024

Fix on the Synapse side to make sure we return a sensible error: element-hq/synapse#17661

@t3chguy
Copy link
Member

t3chguy commented Sep 12, 2024

Duplicate of #6847

@t3chguy t3chguy marked this as a duplicate of #6847 Sep 12, 2024
@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-OIDC A-Registration O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants