Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require acknowledgement to send to a verified user if their identity changed or a device is unverified #27943

Closed
Tracked by #2491
richvdh opened this issue Aug 22, 2024 · 3 comments
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely T-Feature Request to add a new feature which does not exist right now

Comments

@richvdh
Copy link
Member

richvdh commented Aug 22, 2024

In "legacy/transition" mode:

When sending to a VERIFIED user with insecure devices, currently

  • Currently on Web, we display a red shield on the room and user, but we do send the message.
  • Currently on Element X, we fail to send and show a useful warning and a "Send anyway" button.

When sending to a user with VERIFICATION VIOLATION:

  • Currently on Web, we display a red shield on the room and user, but we do send the message.
  • Currently on Element X, we fail to send and show a useful warning and a "Withdraw verification and send" button.

So all of these cases are "okish" and "soon" we will move to "ignore insecure devices" mode.

In "ignore insecure devices" mode

When sending to a VERIFIED user with insecure devices, currently

  • Currently on Web, we show red shields, and we silently do not send. (TODO: no need for shields any more, but we don't care much right now - no harm done.)
  • Currently on Element X, we don't show shields and we silently do not send.

When sending to a user with VERIFICATION VIOLATION:

  • Currently on both, we fail to send with a useless error and Retry button that won't work*

TODO: block the composer #2492

@richvdh
Copy link
Member Author

richvdh commented Aug 27, 2024

Possibly matrix-org/matrix-rust-sdk#3662 does most of the groundwork for this but we need to actually wire it up in web and make sure it works

@andybalaam
Copy link
Member

andybalaam commented Sep 16, 2024

Moving to unprioritised backlog because once element-hq/element-meta#2492 is done, this will be very rare (for identity changes), and it is not a security problem - just a misleading error message when the message fails to send.

Note: ideally, instead of showing an error message, we would pick up the draft message and display it in the composer, with the warning banner already visible.

@andybalaam
Copy link
Member

Based on discussion in Design Hour 2024-10-07 we re-wrote the top description and decided there is nothing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely T-Feature Request to add a new feature which does not exist right now
Projects
None yet
Development

No branches or pull requests

2 participants