Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loading of entire web app #27794

Closed
mpeter50 opened this issue Jul 21, 2024 · 6 comments
Closed

Endless loading of entire web app #27794

mpeter50 opened this issue Jul 21, 2024 · 6 comments
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@mpeter50
Copy link

Steps to reproduce

  1. I wanted to open this link: https://matrix.to/#/#vger.app:matrix.org
  2. So I attempted to open it with my homeserver's web client this way: https://riot.grin.hu/#/#vger.app:matrix.org

Outcome

What did you expect?

I expected the client to load up, and open the room I have put in the link

What happened instead?

The client started loading, I see the spinner (which is still moving, not frozen) and the log out button, but this has been going for 13 minutes now.

Additional information

Reloading, and reloading-without-cache multiple times did not help to solve the issue.
Application version was found by opening the client in a new container tab, and finding the "startUpdater, current version is 1.11.71" log message in the browser dev console, hopefully this is what you mean.

I will not be sending the normal logs, because I am unable to.
I'll upload console logs instead.

Operating system

No response

Browser information

Firefox 126.0.1

URL for webapp

https://riot.grin.hu/

Application version

1.11.71

Homeserver

https://matrix.grin.hu/

Will you send logs?

No

@dosubot dosubot bot added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Critical Prevents work, causes data loss and/or has no workaround labels Jul 21, 2024
@mpeter50
Copy link
Author

The console logs: https://gist.github.com/mpeter50/cdadf67268bca53ca1fc2216f1eef992

According to the devtools, all log messages that are not an error come from rageshake.ts:77:16

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2024

all log messages that are not an error come from rageshake.ts:77:16

That's because rageshake intercepts all logs to store them in IndexedDB also in case you want to submit or download them at a later date.

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2024

(Reason: CORS header ‘Access-Control-Allow-Origin’ missing) all these CORS errors show that matrix.grin.hu isn't spec compliant.

https://spec.matrix.org/v1.11/client-server-api/#web-browser-clients

Closing as a server problem

@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
@grinapo
Copy link

grinapo commented Jul 23, 2024

@t3chguy the server is spec compliant, there is no point providing CORS for a 404. Probably the problem is not related to the report.

@grinapo
Copy link

grinapo commented Jul 23, 2024

…in fact the problem was uglier: apache2 required AllowEncodedSlashes NoDecode in its revproxy config since keys contain percents in random positions, and %2f is an immediate 404 due to security reasons.

@t3chguy
Copy link
Member

t3chguy commented Jul 24, 2024

there is no point providing CORS for a 404

Yes there is, as otherwise the client can't read that the status code is a 404, nor the Matrix errcode, thus cannot behave correctly. The spec I linked does not say "except on 404"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants