Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we fail gracefully when we can't load wasm #27735

Closed
dbkr opened this issue Jul 15, 2024 · 4 comments · Fixed by #27776
Closed

Ensure we fail gracefully when we can't load wasm #27735

dbkr opened this issue Jul 15, 2024 · 4 comments · Fixed by #27776
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning

Comments

@dbkr
Copy link
Member

dbkr commented Jul 15, 2024

Your use case

Since Element web R, we require wasm support since the rust crypto doesn't come with an asm.js version. We should make sure that we fail gracefully when we can't load the rust crypto, and ideally have a test to assert it (see also #27734).

Have you considered any alternatives?

No response

Additional context

No response
@dbkr dbkr added the T-Task Tasks for the team like planning label Jul 15, 2024
@dosubot dosubot bot added A-Element-R Issues affecting the port of Element's crypto layer to Rust S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 15, 2024
@dbkr
Copy link
Member Author

dbkr commented Jul 18, 2024

For the record the current failure mode is:

  • If you're not logged in, presents the welcome screen as normal but if you try to log in, just spins forever
  • If you're logged in, unable to restore session

@t3chguy
Copy link
Member

t3chguy commented Jul 18, 2024

We should probably have a Modernizr rule for WASM https://developer.mozilla.org/en-US/docs/WebAssembly/JavaScript_interface/instantiateStreaming_static

@dbkr dbkr mentioned this issue Jul 18, 2024
Merged
4 tasks
@dbkr
Copy link
Member Author

dbkr commented Jul 18, 2024

Added in #27776

@richvdh
Copy link
Member

richvdh commented Jul 22, 2024

This appears to have been a duplicate of #27424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a modernizr check for WebAssembly support element-hq/element-web
3 participants
@dbkr @richvdh @t3chguy