Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show video room specific dialog also for "RoomType.UnstableCall" #27511

Closed
menturion opened this issue Jun 1, 2024 · 1 comment · Fixed by #28497
Closed

Show video room specific dialog also for "RoomType.UnstableCall" #27511

menturion opened this issue Jun 1, 2024 · 1 comment · Fixed by #28497
Assignees
@t3chguy
Labels
A-Create-Room Create room flow, user suggestions, etc. A-Element-Call Group calls via Element Call T-Enhancement Z-Labs

Comments

@menturion
Copy link

menturion commented Jun 1, 2024 •
edited
Loading

Your use case

Show video room specific dialog also for RoomType.UnstableCall by changing line ...

https://github.com/matrix-org/matrix-react-sdk/blob/fa7486e415bc29ef49ce8b78d569bad186b6d1ca/src/components/views/dialogs/CreateRoomDialog.tsx#L266

to

const isVideoRoom = this.props.type === RoomType.ElementVideo || this.props.type === RoomType.UnstableCall;
@dosubot dosubot bot added A-Create-Room Create room flow, user suggestions, etc. A-Element-Call Group calls via Element Call labels Jun 1, 2024
@dbkr
Copy link
Member

dbkr commented Jun 27, 2024

This one could do with a little clarification and talking about the actual impact / experience for users rather than the code-level change.

@dbkr dbkr added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jun 27, 2024
@t3chguy t3chguy self-assigned this Nov 20, 2024
@t3chguy t3chguy removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Nov 20, 2024
@t3chguy t3chguy mentioned this issue Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Create-Room Create room flow, user suggestions, etc. A-Element-Call Group calls via Element Call T-Enhancement Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider org.matrix.msc3417.call as video room in create room dialog element-hq/element-web
3 participants
@dbkr @t3chguy @menturion