Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to do self-verification with legacy crypto #27485

Closed
florianduros opened this issue May 17, 2024 · 5 comments
Closed

Unable to do self-verification with legacy crypto #27485

florianduros opened this issue May 17, 2024 · 5 comments
Labels
A-E2EE A-E2EE-SAS-Verification O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@florianduros
Copy link
Member

florianduros commented May 17, 2024 •
edited
Loading

Steps to reproduce

  1. Session A is verified
  2. Session B is unverified
  3. Launch session verification between the 2 sessions
  4. Use emji SAS
  5. Click on match in both sessions

Outcome

What did you expect?

I'm expecting the sessions B to be verified

What happened instead?

fffd29a7-b38f-454f-9d73-d3609c04675e

After the click of the two matchs button, this request is made:
/v3/sendToDevice/m.key.verification.cancel/*****

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

Local develop, Crypto version: Olm 3.2.15

Homeserver

matrix.org

Will you send logs?

Yes
@florianduros florianduros added T-Defect S-Critical Prevents work, causes data loss and/or has no workaround A-E2EE A-E2EE-SAS-Verification O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience X-Regression labels May 17, 2024
@florianduros florianduros changed the title Unable to do self-verification Unable to do self-verification with legacy crypto May 17, 2024
@ara4n
Copy link
Member

ara4n commented May 17, 2024

if this only impacts legacy crypto, i'd ignore it, and focus on rolling forwads E-R

@florianduros
Copy link
Member Author

So let's change it to major instead of critical.

@florianduros florianduros added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Critical Prevents work, causes data loss and/or has no workaround labels May 17, 2024
@MidhunSureshR MidhunSureshR mentioned this issue May 23, 2024
Open
@richvdh
Copy link
Member

richvdh commented Jul 23, 2024

@florianduros is this still a problem?

@florianduros
Copy link
Member Author

all my devices are migrated to the new crypto, I can't reproduce it

@richvdh
Copy link
Member

richvdh commented Jul 23, 2024

let's close then

@richvdh richvdh closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-E2EE-SAS-Verification O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @richvdh @florianduros