Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAC indicator doesn't update immediately #26990

Closed
dbkr opened this issue Feb 8, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12243
Closed

TAC indicator doesn't update immediately #26990

dbkr opened this issue Feb 8, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12243
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Feb 8, 2024

Steps to reproduce

Having just been debugging this, the TAC checking for unread threads races with event decryption so sometimes the event will not yet be decrypted when the TAC checks for unread threads. This means the TAC dot won't update until the next time the app syncs.

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@dbkr dbkr added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Threads labels Feb 8, 2024
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 12, 2024
But throttled so we don't kill the client

Fixes element-hq/element-web#26990
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 13, 2024
* Update the TAC indicator on event decryption

But throttled so we don't kill the client

Fixes element-hq/element-web#26990

* Just pass the function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant