Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML chat exports appear to be missing CSS, and their text is weirdly small #26761

Closed
turt2live opened this issue Dec 14, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12774
Assignees
Labels
A-Export-Chat O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Export a room using the HTML format. Timeline settings are not terribly relevant.
  2. Open that export after extracting it.

Outcome

What did you expect?

A prettier export.

What happened instead?

image

It feels like when Compound (or similar) was introduced, a critical set of class names/selectors changed, but the export code wasn't made aware of those changes.

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023121201 Crypto version: Olm 3.2.15

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

Yes

@turt2live
Copy link
Member Author

also worth noting that the avatars aren't loading, but the export does contain them. This might be a Windows issue, though.

@t3chguy t3chguy added X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Export-Chat labels Dec 15, 2023
@ara4n
Copy link
Member

ara4n commented Jan 5, 2024

this isn't uncommon; it consistently breaks the whole feature...

@ara4n ara4n added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely and removed S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 5, 2024
@t3chguy
Copy link
Member

t3chguy commented Jan 5, 2024

Its uncommon because we don't believe the feature is widely used, there's no upvotes on the issue to suggest otherwise hence "Most users are unlikely to come across this issue"

@lampholder
Copy link
Member

I use this more and more now we don't share keys on invite, and the generated HTML is genuninely difficult to read (when it used to be great).

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2024

Can confirm the regression is due to Compound adoption

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2024

So this is made interesting by the JS CSS API being super weird

image

This rule gets exploded into a bunch of blank rules

image

Looks like the issue is explained a little in https://www.w3.org/TR/css-variables-1/#variables-in-shorthands

Chrome & FF behave identically, and Chrome closed it as a wontfix https://issues.chromium.org/issues/40252592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Export-Chat O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants