Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow starting EC calls with new room header #26661

Closed
toger5 opened this issue Nov 28, 2023 · 2 comments
Closed

Allow starting EC calls with new room header #26661

toger5 opened this issue Nov 28, 2023 · 2 comments
Labels
T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team

Comments

@toger5
Copy link
Contributor

toger5 commented Nov 28, 2023

Your use case

With the new room header we need a way to start new issues.
With the ongoing effort to move to EC by default.
@fkwp and I decided we would like to base this on two conditions:

  • If the EC group call feature flag is turned off, we never use EC
  • In the EW settings json one can configure what room type uses which call system (jitsy, EC, Legacy) Clicking call uses the configured option.

This keeps the UX the same (simple, no popup and also the behaviour is the same) but it gives the option to move different deployments to different call systems.

@MidhunSureshR MidhunSureshR added X-Needs-Design X-Needs-Product More input needed from the Product team labels Nov 29, 2023
@toger5
Copy link
Contributor Author

toger5 commented Nov 29, 2023

https://github.com/matrix-org/matrix-react-sdk/blob/7efd2476569acaa655375278670e7fa1dc7ef5bb/src/utils/room/placeCall.ts#L49-L53

It seems like a dropdown could be an option as well once its part of Compound.

@toger5
Copy link
Contributor Author

toger5 commented Jun 13, 2024

This is now implemented

@toger5 toger5 closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

2 participants