Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Jest test createMessageContent › Richtext composer input › Should create html message #26650

Closed
andybalaam opened this issue Nov 27, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11975
Closed

Flaky Jest test createMessageContent › Richtext composer input › Should create html message #26650

andybalaam opened this issue Nov 27, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11975
Assignees
@andybalaam
Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@andybalaam
Copy link
Member

andybalaam commented Nov 27, 2023 •
edited
Loading

I saw this in one of my PRs, and then also here:

https://github.com/matrix-org/matrix-react-sdk/actions/runs/7003936866/job/19050658498?pr=11942
(for PR matrix-org/matrix-react-sdk#11942 )

FAIL test/components/views/rooms/wysiwyg_composer/utils/createMessageContent-test.ts (8.642 s)
  ● createMessageContent › Richtext composer input › Should create html message

    thrown: "Exceeded timeout of 5000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      43 |
      44 |     describe("Richtext composer input", () => {
    > 45 |         it("Should create html message", async () => {
         |         ^
      46 |             // When
      47 |             const content = await createMessageContent(message, true, { permalinkCreator });
      48 |

      at it (test/components/views/rooms/wysiwyg_composer/utils/createMessageContent-test.ts:45:9)
      at describe (test/components/views/rooms/wysiwyg_composer/utils/createMessageContent-test.ts:44:5)
      at Object.describe (test/components/views/rooms/wysiwyg_composer/utils/createMessageContent-test.ts:25:1)
@andybalaam andybalaam added T-Defect Z-Flaky-Test A test is raising false alarms S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 27, 2023
@t3chguy
Copy link
Member

t3chguy commented Nov 27, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/7004851365

@t3chguy
Copy link
Member

t3chguy commented Nov 27, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/7004896043

@t3chguy
Copy link
Member

t3chguy commented Nov 28, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/7022979481/job/19108448409?pr=11963

@t3chguy
Copy link
Member

t3chguy commented Nov 28, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/7022999214/job/19108511388?pr=11967

andybalaam added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 29, 2023
@andybalaam
Prevent flaky Jest test by pre-loading WASM
d19efdd 
Fixes element-hq/element-web#26650
@andybalaam andybalaam mentioned this issue Nov 29, 2023
Merged
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 29, 2023
@andybalaam
Prevent flaky Jest test by pre-loading WASM (#11975)
c5377bc 
Fixes element-hq/element-web#26650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andybalaam andybalaam

Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent flaky Jest test by pre-loading WASM matrix-org/matrix-react-sdk
2 participants
@andybalaam @t3chguy