Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX : "Notifications" onboarding task should be named "Desktop notifications" #26549

Closed
estellecomment opened this issue Nov 10, 2023 · 11 comments · Fixed by matrix-org/matrix-react-sdk#12839
Assignees

Comments

@estellecomment
Copy link

estellecomment commented Nov 10, 2023

Steps to reproduce

Edit 2024-07-04 : added screenshots

  1. Where are you starting? What can you see?
    Create account. The "Notifications" task is not complete (as expected).
Screenshot 2024-07-04 at 10 47 33 AM
  1. What do you click?
    Go to user settings > notifications, enable notifications
Screenshot 2024-07-04 at 10 48 15 AM

Outcome

What did you expect?

Notifications onboarding task is marked complete.

What happened instead?

Even after a refresh, it is still not marked complete.

Why is this happening ?

Because the word "Notifications" is used both for app notifications and for desktop notifications.
What this task checks for is whether the browser has permission to display desktop notifications. It's confusing.

How to fix it ?

Rename the onboarding task "Desktop notifications" instead of "Notifications".

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@Aziz-4980
Copy link

hi @estellecomment can you please assign this to me? I've understood the assignment.

@t3chguy
Copy link
Member

t3chguy commented Nov 11, 2023

@Aziz-4980 - @estellecomment is a member of the community like yourself, they cannot assign issues nor make decisions on behalf of the product.

@gaelledel
Copy link

@estellecomment Hi Estelle, could you please provide more information and attach screenshot here? I don't fully understand what you mean by "notification task" Thanks

@estellecomment
Copy link
Author

@gaelledel I added screenshots.

@gaelledel
Copy link

I see thank you. I'm not convinced we need to make a task checklist for this purpose at all. @amshakal do you have information on this? Can the step on "notifications" be removed? I am missing context for the reasoning.

@amshakal
Copy link

I think it's quite standard to ask people to enable notifications to make sure they recieve messages in real time. It's similar to how on mobile if your notifications are not enabled, you recieve a prompt to enable them as a part of the onboarding flow. Now the question we have to clarify is if we want to enable 'desktop notifications' through this step or just simply enable 'notifications' for the account or device? Regardless, we probably need to clarify through the copy.

@gaelledel
Copy link

Reviewed : we should change the title to "Turn on desktop notifications" and when the user presses on the CTA "enable desktop notifications" we should mark it as Checked regardless if you have changed anything in the toggles or not.

@t3chguy
Copy link
Member

t3chguy commented Jul 25, 2024

@gaelledel maybe the CTA should become Open settings so the user knows clicking it won't perform the enablement immediately so they are more happy to click it to complete the task.

Currently clicking the CTA will ask your browser for permissions to notify, where you'll be met with a browser pop-up. You won't see the settings>notifications page so no toggles involved.

@gaelledel
Copy link

@t3chguy Yes to change the string button to "Open settings". Can we have the task marked as complete when the settings window is opened right after enabling permissions via the browser dialog. This should mark the "Turn on notification" task as complete without the need to activate toggles.
If the user doesn't allow Notifs to be turned in the Browser Permissions dialog then the task should remain as Unchecked as the settings window will not open in this case. The settings window opening acts as an activator for the task to be marked as checked.

@gaelledel
Copy link

Is this issue a good candidate for a maintainer task?

@t3chguy
Copy link
Member

t3chguy commented Jul 26, 2024

Yeah it should be <1h of work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants