Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky matrix-js-sdk jest test: SAS verification › verification › should verify a cross-signing key #26499

Closed
richvdh opened this issue Nov 3, 2023 · 1 comment
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Nov 3, 2023

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6743827349/job/18332493604#step:6:2777

 FAIL  spec/unit/crypto/verification/sas.spec.ts (6.301 s)
  ● SAS verification › verification › should verify a cross-signing key

    thrown: "Exceeded timeout of 5000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      343 |         });
      344 |
    > 345 |         it("should verify a cross-signing key", async () => {
          |         ^
      346 |             alice.httpBackend.when("POST", "/keys/device_signing/upload").respond(200, {});
      347 |             alice.httpBackend.when("POST", "/keys/signatures/upload").respond(200, {});
      348 |             alice.httpBackend.flush(undefined, 2);

      at it (spec/unit/crypto/verification/sas.spec.ts:345:9)
      at describe (spec/unit/crypto/verification/sas.spec.ts:75:5)
      at Object.describe (spec/unit/crypto/verification/sas.spec.ts:37:1)

This is a unit test for legacy crypto, so unlikely to be worth fixing.

@richvdh richvdh added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Flaky-Test A test is raising false alarms labels Nov 3, 2023
@Johennes Johennes added the A-Testing Testing, code coverage, etc. label Nov 8, 2023
@richvdh
Copy link
Member Author

richvdh commented Mar 14, 2024

Since this apparently hasn't happened since November, let's close it.

@richvdh richvdh closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Development

No branches or pull requests

2 participants