Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disabled] Flaky cypress test read receipts > Paging up through old messages after a room is read leaves the room read #26437

Closed
kerryarchibald opened this issue Oct 25, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12017
Closed

[Disabled] Flaky cypress test read receipts > Paging up through old messages after a room is read leaves the room read #26437

kerryarchibald opened this issue Oct 25, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12017
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@kerryarchibald
Copy link
Contributor

kerryarchibald commented Oct 25, 2023 •
edited
Loading

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6630084876/job/18010786208
https://github.com/matrix-org/matrix-js-sdk/actions/runs/6628219729/job/18006485360
https://github.com/matrix-org/matrix-js-sdk/actions/runs/6627896416/job/18004192721
@kerryarchibald
Copy link
Contributor Author

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6627896416/job/18004192721

@kerryarchibald
Copy link
Contributor Author

This flakes in the beforeEach so disabling this specific case will probably just cause the next test to start flaking.

@florianduros
Copy link
Member

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6639269932/job/18037293150

@kerryarchibald kerryarchibald mentioned this issue Oct 26, 2023
Merged
3 tasks
@kerryarchibald
Copy link
Contributor Author

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6641589338/job/18044477493

@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 26, 2023
@weeman1337 weeman1337 changed the title Flaky cypress test read receipts > Paging up through old messages after a room is read leaves the room read [Disabled] Flaky cypress test read receipts > Paging up through old messages after a room is read leaves the room read Oct 26, 2023
@richvdh
Copy link
Member

richvdh commented Oct 26, 2023

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6642883792/job/18048682619#step:8:957

@richvdh
Copy link
Member

richvdh commented Oct 26, 2023

Wonder why this suddenly started failing yesterday. It seems suspicious that matrix-org/matrix-react-sdk#11795 landed yesterday, but given that the test disabled in that PR happens after this one, it is difficult to see why they would be related.

@richvdh richvdh mentioned this issue Oct 26, 2023
Merged
@florianduros florianduros mentioned this issue Dec 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Playwright: Enable skipped tests in high-level.spec.ts matrix-org/matrix-react-sdk
4 participants
@richvdh @florianduros @kerryarchibald @weeman1337