Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CSS Modules class names from Compound rolling all snapshots #26224

Open
germain-gg opened this issue Sep 22, 2023 · 2 comments
Open

Prevent CSS Modules class names from Compound rolling all snapshots #26224

germain-gg opened this issue Sep 22, 2023 · 2 comments
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@germain-gg
Copy link
Contributor

The CSS module hash should be linked to the file name and not tied to the content of the file.

Investigate why matrix-org/matrix-react-sdk#11634 spams the snapshots...
@germain-gg germain-gg self-assigned this Sep 22, 2023
@germain-gg
Copy link
Contributor Author

This is actually the intended behaviour of CSS modules.
Changes to the inner of the CSS will generate a new hash. We might want to change how to remove that from snapshots in the future

@t3chguy t3chguy changed the title investigate css class name hash changing Prevent CSS Modules class names from Compound rolling all snapshots Oct 11, 2023
@t3chguy
Copy link
Member

t3chguy commented Oct 11, 2023

Updated issue to match your findings @germain-gg - also worth noting that Compound itself does this via vitest stubbing out CSS modules classname generation

@t3chguy t3chguy reopened this Oct 11, 2023
@robintown robintown added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Testing Testing, code coverage, etc. A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@germain-gg @t3chguy @robintown