Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show hidden events" doesn't show reaction events anymore #25796

Closed
turt2live opened this issue Jul 13, 2023 · 3 comments
Closed

"Show hidden events" doesn't show reaction events anymore #25796

turt2live opened this issue Jul 13, 2023 · 3 comments

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Send a bunch of reactions
  2. Enable "Show Hidden Events"

Outcome

What did you expect?

To see reaction events.

What happened instead?

They're hidden :(

(it used to work)

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023071301 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No

@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

image

@turt2live works fine for me.

One change in this area is when paginating and we encounter a reaction we do not have the parent event for we do indeed not add it to a timeline as adding it to the correct timeline would require asking the server for the parent event which significantly hurts scrolling performance.

@turt2live
Copy link
Member Author

It's possibly this only happens when someone has spammed reactions outside of the UI - to be investigated further, possibly out of band (related issues have not been opened publicly yet)

@t3chguy
Copy link
Member

t3chguy commented Oct 16, 2023

Closing due to no reproduction

@t3chguy t3chguy closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants