Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Colour contrast and information conveyed exclusively via colour is not accessible #24931

Closed
daniellekirkwood opened this issue Mar 24, 2023 · 8 comments

Comments

@daniellekirkwood
Copy link
Contributor

Information conveyed exclusively via colors is not accessible to blind and color-blind users. Information should therefore also be made available through additional means.

A notice: The contrast ratios in the alternative displays "dark" and "high contrast" also do not
meet the minimum requirements. Selected menu elements (example marked in red) of the navigation areas are contrasted too little with a ratio of 1.2:1 and 1.4:1 compared to non-selected menu elements (example marked in blue). The minimum requirement of 3:1 is therefore not met.

Screenshot 2023-03-24 at 13 11 29

@t3chguy
Copy link
Member

t3chguy commented Mar 24, 2023

Worth pointing out this does not affect screen reader users as we expose the information also via aria-selected

image

@t3chguy
Copy link
Member

t3chguy commented Apr 12, 2023

#14858 #14550

@daniellekirkwood
Copy link
Contributor Author

@janogarcia I'm assigning this to you as while we're working on the colour contrast the actual underlying issue here is how and where we use colour to convey important information which should be addressed as part of the compound work.

@janogarcia
Copy link

janogarcia commented Jul 20, 2023

This won't be relevant anymore once we implement the new designs @americanrefugee has been working on. I'm making sure we don't rely exclusively on color to convey information for the new UIs/components.

@daniellekirkwood
Copy link
Contributor Author

Ok great -- we'll leave this open for now but know that it has a dependancy on that other work.

@janogarcia : Note that while the example shown is the header (soon to be updated) there are likely to be other places in the app that run into these sorts of issues

@daniellekirkwood
Copy link
Contributor Author

@gaelledel & @nadonomy if we have confidence that we are moving away from relying on colour to convey information then this issue can be closed. I have not yet been given that confidence so it's still open. Is there a page in compound that talks about this as a best practice? What are the guardrails we've put in place to not do this in future?

@gaelledel
Copy link

@daniellekirkwood Yes, we're moving towards a more accessible language throughout. You can find guidance on this topic here https://compound.element.io/?path=/docs/foundations-accessibility--docs

@daniellekirkwood
Copy link
Contributor Author

Great! Closing :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants