Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar offset in membership updates in the TL #22744

Open
HarHarLinks opened this issue Jul 6, 2022 · 4 comments
Open

Avatar offset in membership updates in the TL #22744

HarHarLinks opened this issue Jul 6, 2022 · 4 comments
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

image

public accessible test case: https://matrix.to/#/!zzGPdcyFqxIOJEijoI:matrix.org/$WHpUKcDce0SzHUAzjQhHVblI1aFlu_Oo-ThzAIcg0PY?via=matrix.org&via=element.io&via=envs.net

Might apply to non-membership events that are rendered similarly, i.e. might share the css with them or not.

Outcome

What did you expect?

vertical centering with enough padding/resizing to accomodate

What happened instead?

see picture

Operating system

arch

Application version

Element Nightly version: 2022070501 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

No response

Will you send logs?

No

@HarHarLinks HarHarLinks changed the title Avatar offset in member status updates in the TL Avatar offset in membership updates in the TL Jul 6, 2022
@luixxiul
Copy link

luixxiul commented Jul 6, 2022

I suppose it has been fixed with matrix-org/matrix-react-sdk#8965 yesterday, if it is a compact modern layout.

@dbkr dbkr added S-Tolerable Low/no impact on users A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 6, 2022
@t3chguy
Copy link
Member

t3chguy commented Jul 6, 2022

Considering fixed given the Nightly predates the fix.

@t3chguy t3chguy closed this as completed Jul 6, 2022
@HarHarLinks
Copy link
Contributor Author

Yes, my settings are Modern layout + compact layout + Default images.

Updated screenshot using Element Nightly version: 2022070601 Olm version: 3.2.8
image

  • avatar isn't perfectly vertically centered (looks like 0 top but 2 px bottom padding)
  • timestamp has different alignment than either avatar or the event text

you judge whether that's as intended or not

@t3chguy t3chguy reopened this Jul 7, 2022
@luixxiul
Copy link

luixxiul commented Jul 7, 2022

IMO it cannot be fixed perfectly unless flexbox is applied there, which is a big task (which requires the refactoring of EventTile). Otherwise it would be required to modify position with a couple of pixel, though it is a stupid solution considering the fact that each language has different height of characters (mind Arabic languages, Chinese/Japanese/Korean languages, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants