Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the CSS for pill styling in the timeline and the composer #22702

Open
kittykat opened this issue Jun 30, 2022 · 2 comments
Open

Unify the CSS for pill styling in the timeline and the composer #22702

kittykat opened this issue Jun 30, 2022 · 2 comments
Labels
A-Composer A-Pills A-Timeline Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning

Comments

@kittykat
Copy link
Contributor

Currently pills are styled with different CSS in the timeline and composer. This sometimes introduces issues.

We should style pills in both places with the same CSS.
@kittykat kittykat added T-Task Tasks for the team like planning S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline Help Wanted Extra attention is needed A-Composer A-Pills O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jun 30, 2022
@SimonBrandner
Copy link
Contributor

The CSS is mostly unified but isn't unified fully since we use an actual Avatar component in timeline pills though we're forced to use the before pseudoelement in the composer. We could transition to that approach in the timeline too though I am not completely sure if that is desirable

@turt2live
Copy link
Member

consistency is more preferred than correctness in this case so we can stop shipping bugs.

@luixxiul luixxiul mentioned this issue May 18, 2023
Closed
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer A-Pills A-Timeline Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @Johennes @turt2live @SimonBrandner