Date separator lines are barely visible in light mode #22122
Assignees
Labels
A-Timeline
O-Frequent
Affects or can be seen by most users regularly or impacts most users' first experience
S-Minor
Impairs non-critical functionality or suitable workarounds exist
T-Defect
X-Needs-Design
Z-Confidence-High
High confidence in the enhancement or suggestion based on known factors, or as described.
Comments
robintown
added
T-Defect
S-Minor
|
@nadonomy, do you think they should stand out more? |
|
Yeah, perhaps @gaelledel you could suggest a better colour variable for us to use from Compound which will look good on both light & dark? |
|
Removing 'Needs-Design' as will be resolved through EX work. |
|
@rufuskahler removing X-Needs-Design means anyone can just start it with assets already provided in the issue, (e.g. community) - that does not appear to be the case - as without knowing how design expects this to look this will be impossible to contribute. |
|
Removing the a11y label, as it is not a requirement for those decorative lines to pass any contrast check. |
robintown
added a commit
to robintown/matrix-react-sdk
that referenced
this issue
Mar 14, 2024
This is a reintroduction of matrix-org#12255, and should be the last part of the Compound color refinement work (element-hq/element-web#26992). I've updated the following components to reflect design decisions (https://www.figma.com/file/pqhlirZFEwEp5XpudSbiia/Theming-Web-templates?type=design&node-id=80-60219&mode=design&t=mjqwylUie1vRwzOV-0) that will help them fit in better with the new design system: - Message bubbles - Pills - Sent indicators - Jump to bottom/unread buttons - Composer placeholder - Notification badges - Room sublists - Verification shields - Date separators - Tooltips Closes element-hq/element-web#22122
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this issue
Mar 18, 2024
* Refine the colors of some more components This is a reintroduction of #12255, and should be the last part of the Compound color refinement work (element-hq/element-web#26992). I've updated the following components to reflect design decisions (https://www.figma.com/file/pqhlirZFEwEp5XpudSbiia/Theming-Web-templates?type=design&node-id=80-60219&mode=design&t=mjqwylUie1vRwzOV-0) that will help them fit in better with the new design system: - Message bubbles - Pills - Sent indicators - Jump to bottom/unread buttons - Composer placeholder - Notification badges - Room sublists - Verification shields - Date separators - Tooltips Closes element-hq/element-web#22122 * Update some screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Outcome
What did you expect?
The date separator line should have a decent level of contrast
What happened instead?
They're barely visible:
For comparison, they have significantly more contrast in dark theme:
Operating system
NixOS unstable
Browser information
Firefox 99.0.1
URL for webapp
develop.element.io
Application version
Element version: 1783645-react-e05a3e644659-js-706b4d605481 Olm version: 3.2.8
Homeserver
Synapse 1.58.0
Will you send logs?
No
The text was updated successfully, but these errors were encountered: