Can't remove room that's been upgraded from space

[babolivier]

Steps to reproduce

@benparsons reports that he added a room to a space before upgrading the room. Because he happens to be in the old version of the room as well as the new one, Element shows the new room as being in the space as well. But when he tries to remove the room from the space, Element uses the new room ID instead of the new one, and therefore doesn't remove it from the space at all.

Outcome

What did you expect?

Old room is removed from space.

What happened instead?

Old room is still in space.

Operating system

Mac

Browser information

Chrome

URL for webapp

develop.element.io

Application version

762fc53-react-254dbeeccb26-js-41bf8c2d5f4a

Homeserver

element.io

Will you send logs?

No

[babolivier]

(I have asked @benparsons to provide app and system info)

[benparsons]

@benparsons has provided app and system info

[omame]

Same is happening to me. Happy to provide details if needed.

[novocaine]

I can't remove the New Vector Ltd room from a private space. Also, clicking View on the room does nothing. I suspect its due to this, but not sure how to verify.

[babolivier]

I suspect its due to this, but not sure how to verify.

You can check the space's devtools and compare the room ID of the room in the space vs the one of the room in your room list. If they differ, then it's very likely the room in the space is an old iteration that's since been upgraded.

[omame]

For the record, I attempted to leave the room and clean up the spaces (it was only showing in the newest space after I left). Then joined again, to the same situation. 😞

[omame]

Welp, I cleared the cache and the room in question now appeared in the home space. Success, I guess! 😄

[MadLittleMods]

Feels related to element-hq/element-meta#460 and #21685 which was closed in favor of the first issue.

Related to #19209 and #19210

[turt2live]

in the code that does the removal we just need to loop through the room's historical versions (getRoomHistory or whatever it's called) and remove those rooms too.

We should also probably do a similar thing on add so when/if older rooms break they are still somewhat buried into a space, though this would be a different bug/ticket.

[olmari]

We also just hit this when we realized and solved issue where we still had some v1 room which was state-resetted and spammer had something to say... Now said room still "exists" on space but no clicking or "view" does anything... So new/upgaded room exist, we still can't remove whatever room version is seen on space, nor indeed clicking it does anything...

[philiprenich]

This problem still seems to exist. I was part of a Nextcloud room and the Element Web room. Both still show up in my sidebar on Element and when I click Leave, I get a spinner for a few seconds and then it exits me from the room, but does not leave the room. it's still in the sidebar.

https://app.element.io/#/room/#web:element.io
https://app.element.io/#/room/!TEwfEWdDwdaFazXmwD:matrix.org

I'm not sure if they are rooms that were upgrade to spaces as op mentions, but I think the Nextcloud one at least was due to an update.

The rooms show usernames instead of titles. "UsernameA and 4 others..."

This issue has become so annoying that it's one of the top 2 reasons I've stopped using Element and have gone to another UI :( (the other being sync issues which I'm hoping will improve as well) I'm hoping work on this hasn't dropped. I Just want out of the zombie rooms! 😅