Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow composer size to be configurable #17854

Closed
benparsons opened this issue Jul 1, 2021 · 1 comment
Closed

Allow composer size to be configurable #17854

benparsons opened this issue Jul 1, 2021 · 1 comment

Comments

@benparsons
Copy link
Member

Is your suggestion related to a problem? Please describe.

Several customers complain it should be bigger. Is there some way to change constants in code to make it preexpanded to N lines and dynamically grow to M lines?

Describe the solution you'd like.

https://github.com/matrix-org/matrix-react-sdk/blob/78b1f6c0b13efd57031a329a1ac62baba948dad3/res/css/views/rooms/_SendMessageComposer.scss

Currently, the size is controlled by mx_BasicMessageComposer min-height and mx_BasicMessageComposer_input max-height, expressed in pixels. Ideally we could express this in lines of text, and have there be two variables:

  • composer.initialLineHeight
  • composer.maxLineHeight

Where maxLineHeight is the number of lines before scrolling begins.

Describe alternatives you've considered.

The same but still using pixels. I'd prefer lines.

Additional context

Customer ask. This is in a context where they are replacing email, rather than another chat, so needs to be larger area.

@t3chguy
Copy link
Member

t3chguy commented Jul 1, 2021

Duplicate of #5882

@t3chguy t3chguy marked this as a duplicate of #5882 Jul 1, 2021
@t3chguy t3chguy closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants