Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forget calls a membershipChange of 'forget' #17510

Closed
turt2live opened this issue Jun 1, 2021 · 3 comments · Fixed by matrix-org/matrix-js-sdk#4490
Closed

forget calls a membershipChange of 'forget' #17510

turt2live opened this issue Jun 1, 2021 · 3 comments · Fixed by matrix-org/matrix-js-sdk#4490
Assignees
@t3chguy
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

This isn't a membership and is cheating at calling the /forget api
@turt2live turt2live mentioned this issue Jun 16, 2021
Merged
@andybalaam
Copy link
Member

@turt2live is this done? If not, please could you expand the description? I don't understand what this issue means at the moment.

@turt2live
Copy link
Member Author

It's not done to my knowledge - the linked PR should have more information.

Essentially we're abusing an API format when it's not exactly safe to do so.

@weeman1337 weeman1337 added X-Needs-Info This issue is blocked awaiting information from the reporter T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 24, 2022
@turt2live turt2live added T-Task Tasks for the team like planning A-Developer-Experience and removed T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter labels Jun 14, 2022
@Johennes
Copy link
Contributor

Link to code in question: https://github.com/matrix-org/matrix-js-sdk/blob/6deb2bc7a977ee62be0e923bf7d881d0fccf28e6/src/client.ts#L3945

@t3chguy t3chguy mentioned this issue Oct 31, 2024
Merged
@t3chguy t3chguy self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor MatrixClient::forget to not abuse membershipChange API matrix-org/matrix-js-sdk
5 participants
@andybalaam @Johennes @turt2live @t3chguy @weeman1337