Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX Events in Roomlist often doesn't refresh (Context menu, Invites) #17328

Closed
DoM1niC opened this issue May 17, 2021 · 8 comments
Closed

UX Events in Roomlist often doesn't refresh (Context menu, Invites) #17328

DoM1niC opened this issue May 17, 2021 · 8 comments
Labels
A-Room-List S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce X-Regression

Comments

@DoM1niC
Copy link

DoM1niC commented May 17, 2021 •
edited
Loading

UX Refreshing often not works here, Favourite mark don't update refresh / btn state & Roomlist.
Workaround: refreshing or clicking into the Roomlist again apply the changes as a small...

My Element is behind a NGINX via proxy_pass...

Element Web: develop
Synapse: develop
@SimonBrandner
Copy link
Contributor

This feels like a regression to me. Is it?

@SimonBrandner SimonBrandner added A-Room-List A-Tags S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 17, 2021
@robintown
Copy link
Member

Pretty sure it is, it also affects low priority

@SimonBrandner
Copy link
Contributor

SimonBrandner commented May 17, 2021 •
edited
Loading

I've also heard reports of leaving rooms not updating the room-list... This is probably caused by one of the attempts to speed up the room-list

@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 17, 2021
@jryans
Copy link
Collaborator

jryans commented May 18, 2021

Hmm, so far I can't seem to reproduce with e.g. favourites... This feature has always been very server sensitive, because it currently does not local echo the change, so it won't move until the server sends the change back across via sync.

Whenever the server has any performance issues, we often notice this feature "seemingly" not working.

Is that what's actually happening again here, or is there really something broken on the client?

@jryans
Copy link
Collaborator

jryans commented May 18, 2021

#14302 seems like the right issue to follow as far as adding some local echo for this.

@SimonBrandner
Copy link
Contributor

Ok, after doing more tests this is just the fact that there is no local echo. @DoM1niC and @robintown, could you please confirm this?

@DoM1niC
Copy link
Author

DoM1niC commented May 18, 2021

indeed this local echo make sense for me... the UX sometimes response in context but often not .... but this problem still already exist since I use Element/Riot, but currently the fav mark is heavy broken as before....

@DoM1niC DoM1niC changed the title Favourite function is a bit broken UX Events in Roomlist often doesn't refresh (Context menu, Invites) May 18, 2021
@robintown
Copy link
Member

Let's continue to track this at #14302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-List S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @DoM1niC @SimonBrandner @robintown