Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete all" and "Retry all" buttons on "some of your messages have not been sent" doesn't work. #17078

Closed
ara4n opened this issue Apr 27, 2021 · 6 comments
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@ara4n
Copy link
Member

ara4n commented Apr 27, 2021

Screenshot 2021-04-27 at 10 15 21

The 'delete all' button does nothing; nothing in logs. (Also, I don't recall the 'stuck' message actually failing to send at the time :/)

@ara4n ara4n added the T-Defect label Apr 27, 2021
@ara4n
Copy link
Member Author

ara4n commented Apr 27, 2021

...and then I can't send messages in that room at all:

TimelinePanel.js?0670:1214 Uncaught (in promise) TypeError: Cannot read property 'getStateKey' of undefined
    at TimelinePanel._checkForPreJoinUISI (TimelinePanel.js?0670:1214)
    at TimelinePanel._getEvents (TimelinePanel.js?0670:1138)
    at TimelinePanel._reloadEvents (TimelinePanel.js?0670:1132)
    at MatrixClient.eval (TimelinePanel.js?0670:592)
    at MatrixClient.emit (events.js?faa1:158)
    at Room.forSource (ReEmitter.ts?7714:45)
    at Room.emit (events.js?faa1:153)
    at Room.addPendingEvent (room.js?6146:1312)
    at MatrixClient._sendCompleteEvent (client.js?2444:2857)
    at MatrixClient.sendEvent (client.js?2444:2801)

@ara4n ara4n changed the title "Delete all" button on "some of your messages have not been sent" doesn't work. "Delete all" and "Retry all" buttons on "some of your messages have not been sent" doesn't work. Apr 27, 2021
@jryans jryans added P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Apr 27, 2021
@jryans
Copy link
Collaborator

jryans commented Apr 27, 2021

Not sure of the best workaround off hand... Let's check with @turt2live when awake.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 27, 2021
Just in case we're not cleaning up the isResending state properly, here's a catch all.

Unrelated to element-hq/element-web#17078 (this code doesn't affect the js-sdk error the author is seeing)
@turt2live
Copy link
Member

As mentioned internally, it would be good to know what the events are to help identify the failure mode here. Logs would also be useful as they might not show anything on the button clicks, but can at least help reveal how the UI ended up in this state.

@kittykat
Copy link
Contributor

I get this occasionally: usually closing the tab and reopening the app fixes the issue

@erebion
Copy link

erebion commented Nov 27, 2022

I also notice that every now and then and I can't find a reason for that. So far my workaround was starting a new conversation, but that's a bit annoying.

@t3chguy
Copy link
Member

t3chguy commented May 10, 2024

Fixed by matrix-org/matrix-react-sdk#12464 which removes the checkForPreJoinUISI code

@t3chguy t3chguy closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

9 participants